Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional edits to ChickenChiang PPP #173

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Additional edits to ChickenChiang PPP #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions docs/team/chickenchiang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,15 @@ Given below are my contributions to the project.
* Credits: TeamTags takes inspiration for the Tags class from AB3 and heavily mirrors the methods it uses there.

* **New Feature**: JsonAdaptedTeams and JsonAdaptedNames
* What it does: for TeamBuilder to both read and store Teams and their respective members from/into the data file in JsonFormat.
* What it does: For TeamBuilder to both read and store Teams and their respective members from/into the data file in JsonFormat.
* Justification: This feature is necessary for TeamBuilder to reach a minimum viable product stage, as teams will not be lost after users exit the program.
* Credits: This feature heavily references the JsonAdaptedPerson class provided by AB3.


* **New Feature**: UniqueTeamList
* What it does: Allows for TeamBuilder's model component to hold a list of Teams.
* Justification: This feature is necessary for TeamBuilder to function and store teams created by the user.
* Credits: This feature heavily reference the UniquePersonsList from AB3.

* **New Feature**: Allow contacts to have optional fields
* What it does: Allows for users to add or edit a contact such that certain fields are empty, e.g. address, phone number.
* Justification: TeamBuilder is meant for students primarily. Outside a corporate context, it is unlikely that our users will have/require all details regarding a contact.
Expand All @@ -32,13 +37,20 @@ Given below are my contributions to the project.

* **Enhancements to existing features**:
* Updated GUI for tags, team tags, skill tags, and member tags.
* Changed GUI to hide empty fields.
* Changed GUI such that person empty person fields are hidden and take up no space.

* **Documentation**:
* User Guide:
* To be added
* Added future features section.
* Added sample screen shot of Ui as well as description for users to understand what they are looking at.
* Developer Guide:
* To be added.
* Documented AddCommand implementation and created an activity diagram to aid understanding.
* Added Future Enhancement section.
* Added documentation for how optional fields are achieved for person class.

* **Bug fixes**:
* Fixed Ui issue where the TeamList Ui is cutoff when the TeamBuilder window is resized too small.
* Fixed bug where the wrong error is displayed when an invalid index is passed as an argument.

* **Community**:
* Contributed to forum discussions (examples: [#232](https://github.com/nus-cs2103-AY2223S2/forum/issues/232), [#239](https://github.com/nus-cs2103-AY2223S2/forum/issues/239), [#286](https://github.com/nus-cs2103-AY2223S2/forum/issues/286))
Expand Down