Modify the edit command and parser for teamTags #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
============================================
+ Coverage 73.56% 73.57% +0.01%
Complexity 452 452
============================================
Files 77 77
Lines 1407 1408 +1
Branches 148 148
============================================
+ Hits 1035 1036 +1
Misses 325 325
Partials 47 47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
WillCWX
approved these changes
Mar 20, 2023
| @@ -262,6 +262,7 @@ && getPhone().equals(e.getPhone()) | |||
| && getEmail().equals(e.getEmail()) | |||
| && getAddress().equals(e.getAddress()) | |||
| && getMajor().equals(e.getMajor()) | |||
| //&& getTeams().equals(e.getTeams()) | |||
There was a problem hiding this comment.
Is there a reason why this is commented out for now?
Comment on lines
+65
to
+67
| //if (argMultimap.getAllValues(PREFIX_TEAM).isEmpty()) { | ||
| // editPersonDescriptor.setTeams(new HashSet<>()); | ||
| //} |
There was a problem hiding this comment.
I think you should put a reason above commented out codes so we know why the code is not deleted and also why the code is not implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #47
The previous change made for the edit command did not import the PREFIX_TEAM from CliSyntax in EditCommandParser, so edit command for TeamTags is not working.