Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update user guide on the behavior of fav and unfav #237

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Update user guide on the behavior of fav and unfav #237

merged 3 commits into from
Apr 12, 2024

Conversation

tsulim
Copy link
Collaborator

@tsulim tsulim commented Apr 11, 2024

Fixes #205

Explicitly specify the behavior of fav and unfav in the user guide.

image.png

After find james, when I mark the 1s person in the list as favourite using fav 1, the list resets to the default view, as seen below:

image.png

@tsulim tsulim added the type.Documentation Improvements or additions to documentation label Apr 11, 2024
@tsulim tsulim self-assigned this Apr 11, 2024
@tsulim tsulim added this to the v1.4 milestone Apr 11, 2024
whitesnowx
whitesnowx approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@whitesnowx whitesnowx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👩‍🍳 🔥 🚒

@whitesnowx whitesnowx merged commit 623ba30 into AY2324S2-CS2103-F08-3:master Apr 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitesnowx whitesnowx whitesnowx approved these changes

Assignees

@tsulim tsulim

Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester E] fav & unfav resets the view to default
2 participants
@tsulim @whitesnowx