Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update User guide #187

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Update User guide #187

merged 2 commits into from
Apr 4, 2024

Conversation

jinhanfromNUS
Copy link

No description provided.

ashleyclx
ashleyclx reviewed Apr 4, 2024
View reviewed changes
Copy link

@ashleyclx ashleyclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits to pick

docs/UserGuide.md Outdated
9. Only Borrow, Donate and Return command is for managing books.
1. Every user starts from merit score 0.
1. Donating increases merit score by 1.
1. Borrowing is **ONLY** allowed for user with **Merit Score >= Threshold** (Threshold can be set by using `Set` Command.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be limit command not Set

@Darkarche3 Darkarche3 self-assigned this Apr 4, 2024
@Darkarche3 Darkarche3 added type.Documentation Improvements or additions to documentation priority.High labels Apr 4, 2024
@Darkarche3 Darkarche3 added this to the v1.3 milestone Apr 4, 2024
ashleyclx
ashleyclx approved these changes Apr 4, 2024
View reviewed changes
Copy link

@ashleyclx ashleyclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashleyclx ashleyclx merged commit c2590f8 into AY2324S2-CS2103T-F11-2:master Apr 4, 2024
0 of 3 checks passed
@jinhanfromNUS jinhanfromNUS deleted the UpdateUG branch April 13, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyclx ashleyclx ashleyclx approved these changes

Assignees

@Darkarche3 Darkarche3

Labels
priority.High type.Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jinhanfromNUS @ashleyclx @Darkarche3