Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testcase for v1.3 #196

Merged

Conversation

ashleyclx
Copy link

No description provided.

@ashleyclx ashleyclx added type.Task Something that needs to be done, but not a story, bug, or an epic priority.High labels Apr 4, 2024
@ashleyclx ashleyclx added this to the v1.3 milestone Apr 4, 2024
@ashleyclx ashleyclx self-assigned this Apr 4, 2024
Copy link

@meowwtama meowwtama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.28%. Comparing base (72e35f5) to head (53590c2).
Report is 144 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #196       +/-   ##
=============================================
- Coverage     73.73%   63.28%   -10.46%     
- Complexity      474      482        +8     
=============================================
  Files            82       91        +9     
  Lines          1607     1915      +308     
  Branches        162      188       +26     
=============================================
+ Hits           1185     1212       +27     
- Misses          371      643      +272     
- Partials         51       60        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meowwtama meowwtama merged commit e791046 into AY2324S2-CS2103T-F11-2:master Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High type.Task Something that needs to be done, but not a story, bug, or an epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants