Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PPP #346

Merged

Conversation

Darkarche3
Copy link

No description provided.

@Darkarche3 Darkarche3 added the type.Documentation Improvements or additions to documentation label Apr 15, 2024
@Darkarche3 Darkarche3 self-assigned this Apr 15, 2024
Copy link

@jinhanfromNUS jinhanfromNUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to recheck and specify (e.g. What it does and justification) what you have completed, as well as highlights and credits.

Copy link

@jinhanfromNUS jinhanfromNUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinhanfromNUS
Copy link

This merge is solely for PPP purpose, which is allowed by prof (asked in forum). No user guide, developer guide, functional codes or test cases code are changed.

@jinhanfromNUS jinhanfromNUS merged commit 86caf79 into AY2324S2-CS2103T-F11-2:master Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants