Fix EditCompanyName bug #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lalelulilulela
requested review from
Dexter-Wong,
ZHANGTIANYAO1,
dabzpengu and
ashleyy2444
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
============================================
+ Coverage 81.22% 81.47% +0.24%
- Complexity 653 655 +2
============================================
Files 97 97
Lines 2040 2040
Branches 223 223
============================================
+ Hits 1657 1662 +5
+ Misses 327 324 -3
+ Partials 56 54 -2 ☔ View full report in Codecov by Sentry. |
|
LGTM |
ashleyy2444
reviewed
Apr 2, 2024
| @@ -200,7 +200,7 @@ public EditPersonDescriptor(EditPersonDescriptor toCopy) { | |||
| * Returns true if at least one field is edited. | |||
| */ | |||
| public boolean isAnyFieldEdited() { | |||
| return CollectionUtil.isAnyNonNull(name, phone, email, address, dateTime, salary, info, tags, | |||
| return CollectionUtil.isAnyNonNull(companyName, name, phone, email, address, dateTime, salary, info, tags, | |||
There was a problem hiding this comment.
Good job fixing the error
# Conflicts: # src/test/java/seedu/address/model/person/CompanyNameTest.java
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #46
Ensure that company name can be edited