Add sort inverse feature #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
============================================
+ Coverage 80.73% 81.45% +0.72%
- Complexity 634 661 +27
============================================
Files 94 97 +3
Lines 1998 2076 +78
Branches 219 234 +15
============================================
+ Hits 1613 1691 +78
+ Misses 329 328 -1
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
dabzpengu
reviewed
Apr 2, 2024
| @Override | ||
| public int compare(Person p1, Person p2) { | ||
| return Integer.compare(p1.getPriority(), p2.getPriority()); | ||
| int comparisonResult = Integer.compare(p1.getPriority(), p2.getPriority()); | ||
| return isReverseOrder ? -comparisonResult : comparisonResult; |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sort inverse feature