Fix: remove pop up window for help command #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now less mouse usage is required. Lets optimize for typists.
Zer0Legion
added
type.Task
Now the checkstyle is fixed. Lets adhere to checkstyle.
|
Nice now its more keyboard-friendly |
Now tests should pass on gradle checks. Lets help gradle pass.
Now code adheres to checkstyle. lets adhere to checkstyle.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
============================================
- Coverage 80.30% 80.23% -0.08%
- Complexity 871 873 +2
============================================
Files 106 106
Lines 2589 2595 +6
Branches 299 299
============================================
+ Hits 2079 2082 +3
- Misses 429 431 +2
- Partials 81 82 +1 ☔ View full report in Codecov by Sentry. |
jayllo-c
reviewed
Apr 3, 2024
|
|
||
| public static final String SHOWING_HELP_MESSAGE = "Opened help window."; | ||
| private void copyToClipboard(StringSelection stringSelection) { | ||
| if (GraphicsEnvironment.isHeadless()) { |
There was a problem hiding this comment.
great job ensuring the environment allows for the existence of the clipboard
|
|
||
| @Override | ||
| public CommandResult execute(Model model) { | ||
| return new CommandResult(SHOWING_HELP_MESSAGE, true, false); | ||
| copyToClipboard(USER_GUIDE_URL); |
danielleloh
reviewed
Apr 3, 2024
| public static final String COMMAND_WORD = "help"; | ||
|
|
||
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Shows program usage instructions.\n" | ||
| + "Example: " + COMMAND_WORD; | ||
| public static final String SHOWING_HELP_MESSAGE = | ||
| "Copied user guide link to clipboard. Open the link in a browser to view it."; |
There was a problem hiding this comment.
good catch to optimise the app for keyboard users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now less mouse usage is required.
Lets optimize for typists.