Bug fix: Update name param to include more characters #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the name accepts alphanumerical characters, spaces, and forward slashes. This will allow the majority of names to be added into the app. However, it has come to light that there are names which would contain other characters that would throw errors if users attempt to add these names in, which is problematic since some special characters like `.` and `,` are common. Let's allow several other characters in the regex for names. In doing so, we can ensure that most common names will be successfully added into the application.
Pughal77
reviewed
Apr 3, 2024
| + "and it should not be blank"; | ||
|
|
||
| /* | ||
| * The first character of the address must not be a whitespace, | ||
| * otherwise " " (a blank string) becomes a valid input. | ||
| */ | ||
| public static final String VALIDATION_REGEX = "[\\p{Alnum}][\\p{Alnum} /]{1,79}"; | ||
| public static final String VALIDATION_REGEX = "[\\p{Alnum}][\\p{Alnum} ,-./()]{1,79}"; |
There was a problem hiding this comment.
Nice that the message constraints is all managed in one place!
Zer0Legion
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Good catch, if not we cant even add our groupmate's name inside!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319
Currently, the name accepts alphanumerical characters, spaces, and
forward slashes. This will allow the majority of names to be added
into the app.
However, it has come to light that there are names which would contain
other characters that would throw errors if users attempt to add these
names in, which is problematic since some special characters like
.and
,are common.Let's allow several other characters in the regex for names.
In doing so, we can ensure that most common names will be successfully
added into the application.