-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add page breaks to ensure good formatting of printed user guide #323
fix: add page breaks to ensure good formatting of printed user guide #323
Conversation
* 'master' of https://github.com/AY2324S2-CS2103T-T10-1/tp: (30 commits) Fix naming in javaDoc Fix spelling errors fix: edit information in command summary table fix: typo mistake in user guide Revert "Revert "docs: edit user guide and site layout"" Small changes to test cases Comprehensive testing for `CsvUtil` and `ImportCommand` Replace references of AB3 with AA CsvUtil now throws an IOException for the case when a file is not found in the system Update examples to match images Update images to match success msg Fix: remove magic literal in unit test for import Fix: typos in success messages Satisfy github CI Satisfy Github CI Satisfy github CI actions Satisfy checkstyle checks Update delete example Add more updates to examples Modify examples to fit images ...
* 'master' of https://github.com/AY2324S2-CS2103T-T10-1/tp: Build: update version number Update image for help command Update chars accepted by Name Fix: checkstyle Fix: headless environment for gradle Style: fix checkstyle Fix: remove pop up window for help command
* master: (34 commits) Build: update version number Update image for help command Update chars accepted by Name Fix: checkstyle Fix: headless environment for gradle Style: fix checkstyle Fix: remove pop up window for help command Fix naming in javaDoc Fix spelling errors Small changes to test cases Comprehensive testing for `CsvUtil` and `ImportCommand` Replace references of AB3 with AA CsvUtil now throws an IOException for the case when a file is not found in the system Update examples to match images Update images to match success msg Fix: remove magic literal in unit test for import Fix: typos in success messages Satisfy github CI Satisfy Github CI Satisfy github CI actions ...
Nice! Our pdf would look nicer now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for ensuring the ug is perfectly formatted!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, great job ensuring the UG nicely formats itself when converted to PDF
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
============================================
- Coverage 80.31% 80.23% -0.09%
- Complexity 858 873 +15
============================================
Files 106 106
Lines 2510 2595 +85
Branches 287 299 +12
============================================
+ Hits 2016 2082 +66
- Misses 419 431 +12
- Partials 75 82 +7 ☔ View full report in Codecov by Sentry. |
No description provided.