Small changes to manual testing #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pughal77
added
type.Task
Zer0Legion
reviewed
Apr 13, 2024
| @@ -1540,24 +1540,24 @@ Priorities: High (must have) - `* * *`, Medium (nice to have) - `* *`, Low (unli | |||
| **MSS:** | |||
|
|
|||
| 1. User requests to edit a specific person with updated details. | |||
| 2. AddressBook saves the updated details. | |||
| 3. AddressBook confirms the successful update. | |||
| 2. AvengersAssemble saves the updated details. | |||
There was a problem hiding this comment.
Good spot. We should remove references to address book.
danielleloh
reviewed
Apr 13, 2024
docs/DeveloperGuide.md
Outdated
| <br><br> | ||
| * **Test case (missing score):** `addExam n|Final`<br> | ||
| **Expected:** Error message shown in the error report. No change in the address book. | ||
| **Expected:** Error message shown in the error report. No change in the exams lsit. |
danielleloh
reviewed
Apr 13, 2024
docs/DeveloperGuide.md
Outdated
|
|
||
| Use case ends. | ||
|
|
||
| * 2b. The file to be imported is not a csv file. | ||
|
|
||
| * 2b1. AddressBook displays an error message indicating that the file type is not recognised and should be a csv file | ||
| * 2b1. AvengersAssemble displays an error message indicating that the file type is not recognised and should be a csv file |
…into branch-FinaliseDG # Conflicts: # docs/DeveloperGuide.md
danielleloh
reviewed
Apr 13, 2024
docs/DeveloperGuide.md
Outdated
|
|
||
| <br> | ||
|
|
||
| * **Test case:** `import i|C:\file.csv`<br> | ||
| * **Test case:** `import i|C:\path\to\file.csv`<br> | ||
| **Expected:** Error message shown in the error report. No change in list of persons. | ||
|
|
||
| <br> | ||
|
|
||
| 3. Importing Data from a CSV File that is not a CSV File |
|
LGTM too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shoud remove usages of AddressBook and update it to references to our application, Avengers Assemble