Branch a searchcommand #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
============================================
+ Coverage 74.73% 74.94% +0.21%
- Complexity 442 456 +14
============================================
Files 74 76 +2
Lines 1417 1453 +36
Branches 139 144 +5
============================================
+ Hits 1059 1089 +30
- Misses 324 327 +3
- Partials 34 37 +3 ☔ View full report in Codecov by Sentry. |
peienlim
reviewed
Mar 20, 2024
| /** | ||
| * Format search instructions for every command for display. | ||
| */ | ||
| public class SearchCommand extends Command { |
There was a problem hiding this comment.
Would it be better to change the class name to SearchTagCommand? Since there is a possibility of implementing search by person in the future
There was a problem hiding this comment.
yes. I have renamed it to search tag. As of now, for the current search command, it is named as search only as no implementation of searching by other means exist yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did the search command, have also done the checkstyle