Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch event tag class update #45

Merged

Conversation

peterXGD
Copy link
Collaborator

Created event tag class as a subclass of eventtag.

I genuinely do not know how the other members are going to utilize this class, so I decide to keep the class simple.

The date-time is in "YYYY-mm-dd hh:mm:ss" format, but you can change it to your own likeing (please inform the team first).

EventTag class is implemented as a subclass.
This allows the implementation of features in v1.3.

Let's add the EventTag class to enable other members to start coding.
* branch-UG-Update:
  Update EventTag Class
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 68.66%. Comparing base (7db997e) to head (d4e0f5f).

Files Patch % Lines
...rc/main/java/seedu/address/model/tag/EventTag.java 0.00% 20 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 60.00% 2 Missing ⚠️
src/main/java/seedu/address/MainApp.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
- Coverage     69.54%   68.66%   -0.89%     
- Complexity      471      472       +1     
============================================
  Files            81       82       +1     
  Lines          1609     1634      +25     
  Branches        165      170       +5     
============================================
+ Hits           1119     1122       +3     
- Misses          447      469      +22     
  Partials         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterXGD
Copy link
Collaborator Author

peterXGD commented Mar 28, 2024

please approve this so that we can update the release Jar, which is counted for participation

Copy link
Collaborator

@peienlim peienlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterXGD peterXGD merged commit 0692a5b into AY2324S2-CS2103T-T11-3:master Mar 29, 2024
3 of 5 checks passed
@peterXGD peterXGD self-assigned this Mar 29, 2024
@peterXGD peterXGD added this to the v1.3 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants