Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the tag field from EditCommand and update the EditPersonDescriptor accordingly #91

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

yyccbb
Copy link

@yyccbb yyccbb commented Apr 1, 2024

Resolves #55 #89

@yyccbb yyccbb added this to the v1.3b milestone Apr 1, 2024
@yyccbb yyccbb self-assigned this Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.32%. Comparing base (7b5dc76) to head (90d2425).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #91      +/-   ##
============================================
- Coverage     77.56%   77.32%   -0.25%     
- Complexity      512      520       +8     
============================================
  Files            82       84       +2     
  Lines          1591     1627      +36     
  Branches        157      158       +1     
============================================
+ Hits           1234     1258      +24     
- Misses          313      320       +7     
- Partials         44       49       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yyccbb yyccbb requested a review from wang-xinrong April 1, 2024 16:09
Copy link

@wang-xinrong wang-xinrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yyccbb yyccbb merged commit e2ce908 into AY2324S2-CS2103T-T11-4:master Apr 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditPersonDescriptor: exclude non-editable properties
2 participants