Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seedData functionality #40

Merged
merged 6 commits into from
Mar 17, 2024

Conversation

kokerinks
Copy link

Closes #9

@kokerinks kokerinks added this to the v1.2 milestone Mar 7, 2024
@kokerinks kokerinks self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.86%. Comparing base (1d27b90) to head (5baf283).
Report is 17 commits behind head on master.

Files Patch % Lines
.../seedu/address/logic/parser/AddressBookParser.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #40      +/-   ##
============================================
+ Coverage     75.26%   75.86%   +0.60%     
- Complexity      419      426       +7     
============================================
  Files            71       72       +1     
  Lines          1338     1351      +13     
  Branches        126      129       +3     
============================================
+ Hits           1007     1025      +18     
+ Misses          301      295       -6     
- Partials         30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@billyhoce billyhoce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good! But test cases might not be as complete, after fixing that, it should be all good!

@billyhoce
Copy link

Also, you might want to consider using main/java/seedu.address/model/util/SampleDataUtil

@kokerinks kokerinks requested a review from billyhoce March 14, 2024 19:03
@kokerinks kokerinks added the type.Story A user story label Mar 14, 2024
@billyhoce
Copy link

LGTM!

@kinjalagarwal1810
Copy link

Looks good!

@billyhoce billyhoce merged commit eab9b7c into AY2324S2-CS2103T-T13-4:master Mar 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user exploring the app, I can populate the app with sample data
3 participants