Fix appointment bug #110
Merged
Fix appointment bug #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
============================================
+ Coverage 79.49% 79.52% +0.02%
Complexity 673 673
============================================
Files 107 107
Lines 2063 2066 +3
Branches 214 214
============================================
+ Hits 1640 1643 +3
Misses 366 366
Partials 57 57 ☔ View full report in Codecov by Sentry. |
officialchengyud
approved these changes
Apr 3, 2024
| @@ -11,6 +11,7 @@ | |||
| import seedu.address.model.Model; | |||
| import seedu.address.model.appointment.Appointment; | |||
| import seedu.address.model.appointment.exceptions.InvalidAppointmentException; | |||
| import seedu.address.model.person.exceptions.PersonNotFoundException; | |||
There was a problem hiding this comment.
Good job for adding in an exception.
| @@ -160,7 +160,7 @@ private boolean personsAreUnique(List<Person> persons) { | |||
| return true; | |||
| } | |||
|
|
|||
| public Person getPersonByNric(Nric nricObj) { | |||
| public Person getPersonByNric(Nric nricObj) throws PersonNotFoundException { | |||
There was a problem hiding this comment.
Nice! This looks good to me.
officialchengyud
merged commit f9f8204
into
AY2324S2-CS2103T-T15-1:master
5 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.