Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name constraints #118

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

alfaloo
Copy link
Collaborator

@alfaloo alfaloo commented Apr 4, 2024

No description provided.

@alfaloo alfaloo self-assigned this Apr 4, 2024
@alfaloo alfaloo linked an issue Apr 4, 2024 that may be closed by this pull request
Copy link
Collaborator

@ararchch ararchch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


/*
* The first character of the address must not be a whitespace,
* otherwise " " (a blank string) becomes a valid input.
*/
public static final String VALIDATION_REGEX = "[\\p{Alnum}][\\p{Alnum} ]*";
public static final String VALIDATION_REGEX = "[a-zA-Z][a-zA-Z ]*";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (f9f8204) to head (c3d04b2).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage     79.52%   79.52%           
  Complexity      673      673           
=========================================
  Files           107      107           
  Lines          2066     2066           
  Branches        214      214           
=========================================
  Hits           1643     1643           
  Misses          366      366           
  Partials         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ararchch ararchch merged commit 9c22537 into AY2324S2-CS2103T-T15-1:master Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addpatient/adddoctor name can be all numbers
2 participants