Branch UI change #101
Merged
Branch UI change #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change position of tag to align to the right side of the person card. Added color background for tag ui If there is no tag assign to the person, no tag ui will be displayed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ui-beautification #101 +/- ##
=======================================================
- Coverage 76.44% 75.68% -0.77%
Complexity 521 521
=======================================================
Files 82 82
Lines 1690 1707 +17
Branches 169 171 +2
=======================================================
Hits 1292 1292
- Misses 347 364 +17
Partials 51 51 ☔ View full report in Codecov by Sentry. |
| TagType tagType = person.getTag().value; | ||
| switch (tagType) { | ||
| case Professor: | ||
| tagColor = Color.HOTPINK; |
Comment on lines
+34
to
+35
| <!-- Spacer for aligning the tag at the right --> | ||
| <Region HBox.hgrow="ALWAYS"/> |
There was a problem hiding this comment.
Good comment that details the functionality of the following line
Ragnapop
reviewed
Mar 29, 2024
| TagType tagType = person.getTag().value; | ||
| switch (tagType) { | ||
| case Professor: | ||
| tagColor = Color.HOTPINK; |
Comment on lines
30
to
32
| </Label> | ||
| <Label fx:id="nusId" text="\$first" styleClass="cell_big_label" /> | ||
| <Label fx:id="name" text="\$first" styleClass="cell_big_label" /> |
Rikko1204
merged commit 97093ed
into
AY2324S2-CS2103T-T15-2:ui-beautification
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.