Able to delete in group for delete feature #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete command had no functionality to delete via a group. Added this functionality so that it is easier to delete large groups of contacts at once if required.
Modify delete command
hjuntan
reviewed
Mar 27, 2024
| @@ -21,29 +25,69 @@ public class DeleteCommand extends Command { | |||
| public static final String MESSAGE_USAGE = COMMAND_WORD | |||
| + ": Deletes the person identified by the NusId used in the displayed person list.\n" | |||
| + "Parameters: NusId (8 digits long, starting with an 'E'). \n" | |||
| + "Example: " + COMMAND_WORD + " E0123456"; | |||
| + "Example: " + COMMAND_WORD + " id/E0123456\n\n" | |||
There was a problem hiding this comment.
Not sure if this is intentional but there are a double \n here
| @@ -51,7 +51,7 @@ public void parseCommand_clear() throws Exception { | |||
| public void parseCommand_delete() throws Exception { | |||
| NusId testNusId = new NusId("E1234567"); | |||
| DeleteCommand command = (DeleteCommand) parser.parseCommand( | |||
| DeleteCommand.COMMAND_WORD + " " + testNusId); | |||
| DeleteCommand.COMMAND_WORD + " id/" + testNusId); | |||
There was a problem hiding this comment.
I think we can use the ParserUtil prefix instead of adding it ourselves
Closed
|
Closes #51 |
Comment on lines
+41
to
+43
| if (arePrefixesPresent(argMultimap, PREFIX_NUSID) | ||
| && !arePrefixesPresent(argMultimap, PREFIX_GROUP) | ||
| && !arePrefixesPresent(argMultimap, PREFIX_TAG)) { |
There was a problem hiding this comment.
Maybe we really need to create a common method in ParserUtils that accepts an array of args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.