Add TOC and edit UG and DG #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Fix more inconsistencies Fix typo in DG Fix CheckStyle issues Fix inconsistency in UG and DG Edits to UG and DG Change inconsistency of Find in UG Add Find implementation to DG Fix crash related to empty parameters in Find Change fix of "Fix bug where addressbook is unable to load in" Revert "Fix bug where addressbook is unable to load in." Update DeleteCommand.java minor user guide and error message changes Revert "Update Group Validation Regex to accept hyphens"
hjuntan
reviewed
Apr 14, 2024
|
|
||
| * Words in `UPPER_CASE` are the parameters to be supplied by the user.<br> | ||
| > `delete id/NUSID`, `NUSID` is a parameter which need to be supplied. | ||
| > In the delete command as such: `delete id/NUSID`, `NUSID` is a parameter which need to be supplied. | ||
|
|
||
| * Items in square brackets are optional.<br> | ||
| > `n/NAME [t/TAG]` can be used as `n/John Doe t/friend` or simply as `n/John Doe` without specifying the `TAG` as it is optional. | ||
|
|
||
| * Items with `…` after them can be used multiple times or zero times.<br> |
There was a problem hiding this comment.
Can you update the multiplicity to one or more as for the group id/NUSID... allows multiple people to be grouped but need at least one NUSID provided?
| @@ -46,7 +69,7 @@ Let us get started! | |||
|
|
|||
| 1. Copy the file to the folder you want to use as the _home folder_ for AronaPro in your desired location. For demonstration purpose, we will save the downloaded jar file into `test` folder and saved it to `Desktop` on either Mac or Windows machines. | |||
|
|
|||
| 1. Open a command terminal, either by typing `terminal` on Mac or `PowerShell` on windows and perform the following steps to reach the `test` folder created earlier in order to run the application: | |||
| 1. Open a command terminal, either by typing `terminal` on Mac or `PowerShell` on Windows machine and perform the following steps to reach the `test` folder created earlier in order to run the application: | |||
There was a problem hiding this comment.
Interesting specification, but what's the diff LOL
| > * Domain name must end with a domain label at least 2 characters long. | ||
| > * Have each domain label start and end with alphanumeric characters. | ||
| > * Have each domain label consist of alphanumeric characters, separated only by hyphens, if any. | ||
| > * For `TAG``, the valid forms have to be either 1 of these: Professor, TA, Student, None. |
There was a problem hiding this comment.
Might need to specify (Case-sensitive)
If not already done elsewhere.
(Edit: already specified below lol, but ig if you want you can sneakily save one known issue by clearly stating here that it's case sensitive)
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #213, #216, #221