Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter group #45

Merged

Conversation

STELLA-LYE
Copy link

Update feature to filter strictly according to group.

@STELLA-LYE STELLA-LYE added type.story Record user stories to be delivered priority.High To be done first labels Mar 21, 2024
@STELLA-LYE STELLA-LYE added this to the v1.2b milestone Mar 21, 2024
@STELLA-LYE STELLA-LYE self-assigned this Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.80%. Comparing base (a1a2dd0) to head (831d3b7).
Report is 12 commits behind head on master.

Files Patch % Lines
...eedu/address/logic/parser/FilterCommandParser.java 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
+ Coverage     77.49%   77.80%   +0.31%     
- Complexity      461      478      +17     
============================================
  Files            74       77       +3     
  Lines          1462     1505      +43     
  Branches        144      149       +5     
============================================
+ Hits           1133     1171      +38     
- Misses          296      300       +4     
- Partials         33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jocelyn-soh jocelyn-soh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jocelyn-soh jocelyn-soh merged commit 1de8b1b into AY2324S2-CS2103T-W10-4:master Mar 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High To be done first type.story Record user stories to be delivered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants