Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for optional fields to check if its there #218

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

eliotlee68
Copy link

No description provided.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 93.4981%. Comparing base (be2de23) to head (2d833c6).
Report is 20 commits behind head on master.

❗ Current head 2d833c6 differs from pull request most recent head 42ce7ea. Consider uploading reports for the commit 42ce7ea to get more accurate results

Files Patch % Lines
...model/person/AddressContainsKeywordsPredicate.java 0.0000% 1 Missing and 1 partial ⚠️
...l/person/DescriptionContainsKeywordsPredicate.java 0.0000% 1 Missing and 1 partial ⚠️
...ess/model/person/KinContainsKeywordsPredicate.java 0.0000% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##               master       #218        +/-   ##
==================================================
- Coverage     93.8411%   93.4981%   -0.3431%     
- Complexity        716        717         +1     
==================================================
  Files              96         96                
  Lines            1851       1861        +10     
  Branches          182        183         +1     
==================================================
+ Hits             1737       1740         +3     
- Misses             65         68         +3     
- Partials           49         53         +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Rishit02 Rishit02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjanthony2001 pjanthony2001 merged commit 542b0af into AY2324S2-CS2103T-W12-4:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants