Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Display Command #52

Merged
merged 29 commits into from
Apr 3, 2024
Merged

Add Display Command #52

merged 29 commits into from
Apr 3, 2024

Conversation

tejas-1405
Copy link

No description provided.

@tejas-1405 tejas-1405 added this to the v1.3 milestone Mar 23, 2024
@tejas-1405 tejas-1405 self-assigned this Mar 23, 2024
@tejas-1405 tejas-1405 changed the title Create Display class and parser Add Display Command Mar 23, 2024
@tejas-1405 tejas-1405 marked this pull request as draft March 23, 2024 07:39
@tejas-1405 tejas-1405 linked an issue Mar 23, 2024 that may be closed by this pull request
As a social worker, I can view a client's information #39
Closed
pjanthony2001
pjanthony2001 requested changes Mar 27, 2024
View reviewed changes
Copy link

@pjanthony2001 pjanthony2001 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed wrong comment

src/main/java/seedu/address/logic/commands/CommandResult.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/Messages.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/DisplayCommand.java Outdated Show resolved Hide resolved
@tejas-1405 tejas-1405 force-pushed the 39-display-function branch 2 times, most recently from 4e512c5 to 6850f3c Compare March 28, 2024 16:49
@tejas-1405 tejas-1405 force-pushed the 39-display-function branch from ecbeb81 to fa0d434 Compare March 31, 2024 13:39
@pjanthony2001 pjanthony2001 marked this pull request as ready for review April 2, 2024 15:19
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.0884%. Comparing base (7c7cf5a) to head (9cfb251).

❗ Current head 9cfb251 differs from pull request most recent head 7a5fea4. Consider uploading reports for the commit 7a5fea4 to get more accurate results

Files Patch % Lines
...edu/address/logic/parser/DisplayCommandParser.java 75.0000% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##               master        #52        +/-   ##
==================================================
+ Coverage     93.0529%   93.0884%   +0.0355%     
- Complexity        603        619        +16     
==================================================
  Files              80         82         +2     
  Lines            1569       1606        +37     
  Branches          160        163         +3     
==================================================
+ Hits             1460       1495        +35     
  Misses             66         66                
- Partials           43         45         +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Rishit02
Rishit02 reviewed Apr 3, 2024
View reviewed changes
Copy link

@Rishit02 Rishit02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some nitpicks regarding code quality.

src/test/java/seedu/address/logic/commands/DisplayCommandTest.java Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/CommandResult.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/CommandResult.java Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/CommandResult.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/CommandResult.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/DisplayCommand.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/DisplayCommand.java Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/DisplayCommand.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/DisplayCommand.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/parser/DisplayCommandParser.java Show resolved Hide resolved
eliotlee68
eliotlee68 requested changes Apr 3, 2024
View reviewed changes
Copy link

@eliotlee68 eliotlee68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, otherwise LGTM

src/main/java/seedu/address/logic/commands/CommandResult.java Show resolved Hide resolved
src/test/java/seedu/address/logic/parser/AddressBookParserTest.java Outdated Show resolved Hide resolved
Rishit02
Rishit02 approved these changes Apr 3, 2024
View reviewed changes
Copy link

@Rishit02 Rishit02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/main/java/seedu/address/ui/DisplayListPanel.java
Comment on lines +101 to +102
// Change method to utilise optionals instead of directly assuming the fields exist in the Person
// person.getField().map(person -> String).orElse(DEFAULT)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove these comments

@Rishit02 Rishit02 merged commit 283b127 into AY2324S2-CS2103T-W12-4:master Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliotlee68 eliotlee68 eliotlee68 requested changes

@pjanthony2001 pjanthony2001 pjanthony2001 requested changes

@Rishit02 Rishit02 Rishit02 approved these changes

Assignees

@tejas-1405 tejas-1405

Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

As a social worker, I can view a client's information
4 participants
@tejas-1405 @Rishit02 @eliotlee68 @pjanthony2001