Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UML sequence diagram for linkloan command #68

Merged

Conversation

kjw142857
Copy link

Fixes #67.

Adds a UML sequence diagram for the execution of the linkloan command, which includes the Logic and Model components.

Format is similar to the sequence diagram for delete, as shown here.

@kjw142857 kjw142857 added priority.High Must do type.Documentation All things related to documentation labels Mar 21, 2024
@kjw142857 kjw142857 added this to the v1.2b milestone Mar 21, 2024
@kjw142857 kjw142857 self-assigned this Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.21%. Comparing base (f2262c9) to head (5a82071).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage     62.21%   62.21%           
  Complexity      442      442           
=========================================
  Files            84       84           
  Lines          1736     1736           
  Branches        166      166           
=========================================
  Hits           1080     1080           
  Misses          611      611           
  Partials         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kjw142857 kjw142857 requested a review from xiaorui-ui March 21, 2024 14:02
Copy link

@xiaorui-ui xiaorui-ui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do analyze what happens in parseIndex and parseLoan methods(Index and LinkLoanDescriptor)

Optional: What happens between getFilteredPersonList and CommandResult?

@kjw142857
Copy link
Author

Thanks for reviewing! The diagram mainly traces out the sequence flow in the Logic and Model components. For other components (e.g. Person/Loan, Commons), I'm planning to add another sequence diagram for this in the future!

Copy link

@xiaorui-ui xiaorui-ui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xiaorui-ui xiaorui-ui merged commit fce6eb8 into AY2324S2-CS2103T-W13-1:master Mar 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Documentation All things related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Logic & Model Sequence Diagram for linkloan
2 participants