Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #73 Add Analytics class to the developer guide #74

Merged

Conversation

Joseph31416
Copy link

No description provided.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.21%. Comparing base (245eb7b) to head (961d3e3).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #74   +/-   ##
=========================================
  Coverage     62.21%   62.21%           
  Complexity      442      442           
=========================================
  Files            84       84           
  Lines          1736     1736           
  Branches        166      166           
=========================================
  Hits           1080     1080           
  Misses          611      611           
  Partials         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@xiaorui-ui xiaorui-ui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues apart from the diagram!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my impression, this not how self-invocation looks like on the uml. It should look like this instead:
Screenshot 2024-03-26 184600

Copy link

@xiaorui-ui xiaorui-ui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xiaorui-ui xiaorui-ui merged commit 6baca12 into AY2324S2-CS2103T-W13-1:master Mar 26, 2024
5 checks passed
@xiaorui-ui xiaorui-ui added the type.Documentation All things related to documentation label Mar 26, 2024
@xiaorui-ui xiaorui-ui added this to the v1.3 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Documentation All things related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants