Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32 libretro build fixes #58

Merged
merged 2 commits into from
Sep 2, 2018
Merged

win32 libretro build fixes #58

merged 2 commits into from
Sep 2, 2018

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Aug 30, 2018

These are some windows 64-bit and 32-bit build fixes for the libretro port, I do not use windows so I tested this in the libretro fork with the buildbot where the builds succeeded.

Please see libretro#3, libretro#4 and libretro#5.

These are the build errors for reference.

Build failure

../sdl2/dosio.c: In function 'file_dircreate':

../sdl2/dosio.c:193:16: error: too many arguments to function 'mkdir'

  return((short)mkdir(path, 0777));

                ^~~~~

In file included from ../sdl2/libretro/libretro-common/include/retro_dirent.h:41:0,

                 from ../sdl2/dosio.c:10:

C:/msys64/mingw32/i686-w64-mingw32/include/direct.h:59:15: note: declared here

   int __cdecl mkdir(const char *_Path) __MINGW_ATTRIB_DEPRECATED_MSVC2005;

               ^~~~~

make: *** [Makefile.libretro:326: ../sdl2/dosio.o] Error 1

Warnings.

In file included from ../sound/fmgen/fmgen_types.h:4:0,

                 from ../sound/fmgen/fmgen_fmgen.h:10,

                 from ../sound/fmgen/fmgen_opm.h:10,

                 from ../sound/fmgen/fmgen_opm.cpp:9:

../sdl2/libretro/compiler.h:243:0: warning: "FASTCALL" redefined

 #define FASTCALL

 

In file included from C:/msys64/mingw32/i686-w64-mingw32/include/minwindef.h:163:0,

                 from C:/msys64/mingw32/i686-w64-mingw32/include/windef.h:8,

                 from C:/msys64/mingw32/i686-w64-mingw32/include/windows.h:69,

                 from ../sdl2/libretro/compiler.h:35,

                 from ../sound/fmgen/fmgen_types.h:4,

                 from ../sound/fmgen/fmgen_fmgen.h:10,

                 from ../sound/fmgen/fmgen_opm.h:10,

                 from ../sound/fmgen/fmgen_opm.cpp:9:

C:/msys64/mingw32/i686-w64-mingw32/include/winnt.h:262:0: note: this is the location of the previous definition

 #define FASTCALL __fastcall

@AZO234
Copy link
Owner

AZO234 commented Sep 2, 2018

Yes, thanks to yor fix!
Please make libretro a good fix as well.

@AZO234 AZO234 merged commit c03e968 into AZO234:master Sep 2, 2018
@orbea orbea deleted the win32 branch September 2, 2018 14:54
@orbea
Copy link
Contributor Author

orbea commented Sep 2, 2018

Thanks! The libretro fix has already been made. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants