-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdbool.h added in ABLLink.h #41
Conversation
This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4
include/ABLLink.h
Outdated
@@ -29,6 +29,7 @@ | |||
#pragma once | |||
|
|||
#include <stdint.h> | |||
#include <stdbool.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reverse the order of the #include
s so they are in alphabetical order.
Thanks for the fix! To be able to merge your PR I need a signed Contributor License Agreement. You find all the information here: http://ableton.github.io/cla/ |
This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4
http://ableton.github.io/cla/ I can't reach this page |
Hmm. That's unfortunate. The link should be correct. Could you check if https://ableton.github.io/link/ is working for you? If yes, please try https://ableton.github.io/cla/ again. |
yea, now I can download the file. I will send it filled soon. Thank you |
I have just send the cla to cla@ableton.com |
Have you received my CLA? |
Thanks for following up and sorry for the delay! Unfortunately, I haven't received it yet because – as I just found out – it got stuck somewhere in the process chain. |
No problem! If you need I can re send it one more time |
Finally, I've received the CLA. Before I merge I'd like to ask you to squash the two commits. Thanks! |
stdbool.h added in ABLLink.h This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4 stdbool.h added in ABLLink.h This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4
I'm getting this error again when using the xcframework. - Unknown type
name 'bool'
Trying to compile LinkKit 3.1.5 with Xcode 12.4 in a pure SwiftUI
multiplatform app. In iOS, importing ABLLink.h in a Bridging Header. Also
tried importing libc++.
ABLLink.h only has an import statement for stdint and not stdbool.
This also happens in a completely clean project. LinkHut compiles just
fine, but it's not a SwiftUI app/project.
…On Sat, Nov 18, 2017 at 9:35 AM Domenico Merone ***@***.***> wrote:
Closed #41 <#41>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#41 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADyRpxIOKHJzAdq_iPucwHgPFBMh6D7Kks5s3xV7gaJpZM4Ptq4X>
.
|
It seems I accidentally removed the include in a527aa0. Could you please check if this build works for you with SwiftUI? |
This build works! Thanks for the super quick response!
…On Fri, Mar 26, 2021 at 7:44 AM fgo ***@***.***> wrote:
It seems I accidentally removed the include in a527aa0
<a527aa0>.
Could you please check if this build
<https://github.com/Ableton/LinkKit/files/6212465/LinkKit.zip> works for
you with SwiftUI?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6JDJZYQZACC67VOTTXDILTFSMU5ANCNFSM4D5WVYLQ>
.
|
Cool. I published a new release with the fix. |
Change license statement to prepare for making the LinkKit repo public
This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4