Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdbool.h added in ABLLink.h #41

Closed
wants to merge 4 commits into from
Closed

stdbool.h added in ABLLink.h #41

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 4, 2017

This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4

This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4
@@ -29,6 +29,7 @@
#pragma once

#include <stdint.h>
#include <stdbool.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reverse the order of the #includes so they are in alphabetical order.

@cdi-ableton
Copy link
Collaborator

Thanks for the fix! To be able to merge your PR I need a signed Contributor License Agreement. You find all the information here: http://ableton.github.io/cla/

This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4
@ghost
Copy link
Author

ghost commented Oct 6, 2017

http://ableton.github.io/cla/ I can't reach this page

@cdi-ableton
Copy link
Collaborator

Hmm. That's unfortunate. The link should be correct. Could you check if https://ableton.github.io/link/ is working for you? If yes, please try https://ableton.github.io/cla/ again.

@ghost
Copy link
Author

ghost commented Oct 6, 2017

yea, now I can download the file. I will send it filled soon. Thank you

@ghost
Copy link
Author

ghost commented Oct 18, 2017

I have just send the cla to cla@ableton.com

@ghost
Copy link
Author

ghost commented Nov 11, 2017

Have you received my CLA?

@cdi-ableton
Copy link
Collaborator

Thanks for following up and sorry for the delay! Unfortunately, I haven't received it yet because – as I just found out – it got stuck somewhere in the process chain.

@ghost
Copy link
Author

ghost commented Nov 13, 2017

No problem! If you need I can re send it one more time

@cdi-ableton
Copy link
Collaborator

Finally, I've received the CLA. Before I merge I'd like to ask you to squash the two commits. Thanks!

fgo-ableton and others added 2 commits November 18, 2017 18:05
stdbool.h added in ABLLink.h

This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4

stdbool.h added in ABLLink.h

This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4
@ghost ghost closed this Nov 18, 2017
@kennmichael
Copy link
Collaborator

kennmichael commented Mar 26, 2021 via email

@fgo-ableton
Copy link
Contributor

It seems I accidentally removed the include in a527aa0. Could you please check if this build works for you with SwiftUI?

@kennmichael
Copy link
Collaborator

kennmichael commented Mar 26, 2021 via email

@fgo-ableton
Copy link
Contributor

Cool. I published a new release with the fix.

fgo-ableton added a commit that referenced this pull request Nov 28, 2022
Change license statement to prepare for making the LinkKit repo public
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants