-
Notifications
You must be signed in to change notification settings - Fork 0
#162 - Introduce presence of Release Notes to Issues #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#162 - Introduce presence of Release Notes to Issues #164
Conversation
- Add support for Release notes on Issue.
Caution Review failedThe pull request is closed. WalkthroughRefactors to_chapter_row flow by implementing a concrete base in Record and delegating from CommitRecord, IssueRecord, and PullRequestRecord. Extends release-notes extraction to read from Issue bodies as well as PR bodies. Updates tests to include Issue.body and expected bullets. Minor typing import cleanup in GitHub rate limiter. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Builder as ReleaseNotesBuilder
participant Records as Records (Issue/PR/Commit)
participant Base as Record.to_chapter_row()
participant IssueRec as IssueRecord
participant PRRec as PullRequestRecord
User->>Builder: build()
Builder->>Records: iterate and to_chapter_row()
activate Records
Records->>Base: super().to_chapter_row()
activate Base
Base->>Base: added_into_chapters() %% side-effect
Base-->>Records: ""
deactivate Base
alt Issue
Records->>IssueRec: get_rls_notes()
activate IssueRec
IssueRec->>IssueRec: _get_rls_notes_default(record=Issue|PR)
IssueRec-->>Records: extracted notes (from Issue.body if present)
deactivate IssueRec
else Pull Request
Records->>PRRec: get_rls_notes()
activate PRRec
PRRec-->>Records: extracted notes (from PR.body)
deactivate PRRec
end
Records-->>Builder: formatted row + optional notes
deactivate Records
Builder-->>User: aggregated release notes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (7)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Release Notes:
Summary by CodeRabbit
Fixes #162