Fix OpenGL issue in Python virtual environment #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jstone-lucasfilm
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
This proposed change looks good to me, thanks @howetuft, and ideally we should include it in the upcoming 1.38.10 release.
|
Thank you very much. I close! |
|
Sorry, I misunderstood (thought you had merged!!!) |
jstone-lucasfilm
merged commit 091c35f
into
AcademySoftwareFoundation:main
61 checks passed
ehlenl
pushed a commit
to ehlenl/MaterialX
that referenced
this pull request
Apr 12, 2024
kwokcb
added a commit
to kwokcb/MaterialX
that referenced
this pull request
Apr 19, 2024
* Fix OpenGL issue in Python virtual environment (AcademySoftwareFoundation#1766) See issue AcademySoftwareFoundation#1755 * Finalize changelog for 1.38.10 * Improvements to GitHub CI - Upgrade the MacOS_Xcode_14_Python311 build to the MacOS 14 environment. - Remove unneeded steps in virtual framebuffer setup and JavaScript uploads. * Remove unused classes This changelist removes two unused classes, SurfaceShaderNodeGlsl and SurfaceShaderNodeMsl, which are not leveraged in any active code path for MaterialX shader generation. * Add ESSL unit tests This changelist adds initial unit tests for ESSL shader generation, bringing the measured code coverage of MaterialX unit tests to 88.7%. --------- Co-authored-by: howetuft <34142192+howetuft@users.noreply.github.com> Co-authored-by: Jonathan Stone <jstone@lucasfilm.com>
kwokcb
added a commit
to kwokcb/MaterialX
that referenced
this pull request
Apr 19, 2024
* Fix OpenGL issue in Python virtual environment (AcademySoftwareFoundation#1766) See issue AcademySoftwareFoundation#1755 * Finalize changelog for 1.38.10 * Improvements to GitHub CI - Upgrade the MacOS_Xcode_14_Python311 build to the MacOS 14 environment. - Remove unneeded steps in virtual framebuffer setup and JavaScript uploads. * Remove unused classes This changelist removes two unused classes, SurfaceShaderNodeGlsl and SurfaceShaderNodeMsl, which are not leveraged in any active code path for MaterialX shader generation. * Add ESSL unit tests This changelist adds initial unit tests for ESSL shader generation, bringing the measured code coverage of MaterialX unit tests to 88.7%. --------- Co-authored-by: howetuft <34142192+howetuft@users.noreply.github.com> Co-authored-by: Jonathan Stone <jstone@lucasfilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1755