New widget CueLabelSlider both int and float slider
#1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KernAttila
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
DiegoTavares,
IdrisMiles and
splhack
as code owners
This will be used in branch `cuesubmit-jobs-from-config-file`, done here to avoid pulling the whole widget Signed-off-by: Kern Attila GERMAIN <5556461+KernAttila@users.noreply.github.com>
…oat-slider-widgets
DiegoTavares
approved these changes
May 3, 2024
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
…eFoundation#1280) * feat: New widget `CueLabelSlider` both int and float slider * fix: remove feature from another branch * Add `signals`, `getter` and `setter` This will be used in branch `cuesubmit-jobs-from-config-file`, done here to avoid pulling the whole widget Signed-off-by: Kern Attila GERMAIN <5556461+KernAttila@users.noreply.github.com> --------- Signed-off-by: Kern Attila GERMAIN <5556461+KernAttila@users.noreply.github.com>
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
…eFoundation#1280) * feat: New widget `CueLabelSlider` both int and float slider * fix: remove feature from another branch * Add `signals`, `getter` and `setter` This will be used in branch `cuesubmit-jobs-from-config-file`, done here to avoid pulling the whole widget Signed-off-by: Kern Attila GERMAIN <5556461+KernAttila@users.noreply.github.com> --------- Signed-off-by: Kern Attila GERMAIN <5556461+KernAttila@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#1279
Summarize your change.
This PR adds a new
CueLabelSliderwidget.It is an int slider, acting as a float slider when providing the
float_precisionargument.This can improve the user experience, having a slider clearly shows the boundaries of each variable.