Add test for cuesubmit - Validators.py #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated comment for one function in Validators.py
|
|
gregdenton
approved these changes
Dec 21, 2019
There was a problem hiding this comment.
LGTM. @bcipriano do you agree with the comment on whitespaces?
| @@ -28,7 +28,7 @@ def matchLettersAndNumbersOnly(value): | |||
|
|
|||
|
|
|||
| def matchNoSpecialCharactersOnly(value): | |||
| """Match strings containing letters, numbers, '.', '-', and '_'""" | |||
| """Match strings containing letters, numbers, '.', '-','_', \t and \n""" | |||
There was a problem hiding this comment.
This is great example of why tests are great. We probably don't want tabs and newlines in this regex, at least not for where it is currently used. I'll create a separate ticket for cleaning up the regex to remove the general whitespace character and be more explicit about single whitespaces.
|
@kalisp Thanks for the contribution! It's great to be increasing the test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#396
Summarize your change.
Added first tests for Validators
Updated comment for one function in Validators.py based on test result
Validators.py didn't have any test coverage yet