Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking with OpenCV highgui component is not needed for 3.X and newer. #1842

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

hobbes1069
Copy link
Contributor

Description

It is not necessary to link against the OpenCV highgui component in version 3.X and above as it has been split into 3 components.

Checklist:

  • [x ] I have read the contribution guidelines.
  • If this is more extensive than a small change to existing code, I
    have previously submitted a Contributor License Agreement
    (individual, and if there is any way my
    employers might think my programming belongs to them, then also
    corporate).
  • [x ] I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • [x ] My code follows the prevailing code style of this project.

@lgritz
Copy link
Collaborator

lgritz commented Jan 15, 2018

LGTM

@lgritz lgritz merged commit 0f9b9fe into AcademySoftwareFoundation:master Jan 15, 2018
@sambler
Copy link
Contributor

sambler commented Jun 1, 2018

This isn't completely right - libutil/paramlist_test needs to link with highgui.

FAILED: src/libutil/paramlist_test
...
src/libOpenImageIO/libOpenImageIO.so.1.9.3: undefined reference to 'cvCreateCameraCapture'
src/libOpenImageIO/libOpenImageIO.so.1.9.3: undefined reference to 'cvReleaseCapture'
src/libOpenImageIO/libOpenImageIO.so.1.9.3: undefined reference to 'cvQueryFrame'

So at least when building tests we still need to include highgui. That is if paramlist_test should be testing with camera capture.

@hobbes1069
Copy link
Contributor Author

hobbes1069 commented Jun 1, 2018

I'll wait for Larry to comment on whether camera capture is necessary. If so I'll relook at this. I know it's standard practice but I hate globbing libraries together and blindly linking them all or nothing with a target. -Wl,--as-needed can help with this but I don't like relying on it.

@lgritz
Copy link
Collaborator

lgritz commented Jun 2, 2018

No, paramlist_test definitely does not need any OpenCV functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants