Fix Strutil::strtod_l/strtod_l on Hurd #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they are available on any platform that uses GNU libc, enable it directly.
|
LGTM, thanks for the fix! |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 21, 2018
* Strutil: use the right variable * Strutil: use strtod_l/strtod_l on GNU libc Since they are available on any platform that uses GNU libc, enable it directly.
|
I will also backport this to 1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Strutil::strtod_l/strtod_l, so it builds on Hurd, and on systems using the fallback code using the non-_l versions.
Tests
Builds on Hurd, using both fallback code and _l versions.
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).