Fix bug in understanding regex_search & regex_match parameter writes #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an oslc bug a long time ago (prior to OSL 1.10) in which the 3-argument versions of regex_search and regex_match failed to mark their 'results' parameter as write-only in the oso. In addition to fixing the bug in oslc so that subsequently-produced oso files are correct, in order to properly interpret these historically-compiled oso's, we also look for this particular case upon reading the oso, in loadshader.cpp, and mark it correctly. This was PR AcademySoftwareFoundation#922. Except... 1) We neglected to distinguish the 2-arg version from the 3-arg version, only the latter of which should be so marked. 2) We tested for regex_search twice (!) instead of testing for regex_search and also regex_match. Apologies! Here is the fix. Thanks to Alex Wells for identifying the problem. Signed-off-by: Larry Gritz <lg@larrygritz.com>
AlexMWells
approved these changes
May 29, 2020
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Jun 2, 2020
…cademySoftwareFoundation#1186) There was an oslc bug a long time ago (prior to OSL 1.10) in which the 3-argument versions of regex_search and regex_match failed to mark their 'results' parameter as write-only in the oso. In addition to fixing the bug in oslc so that subsequently-produced oso files are correct, in order to properly interpret these historically-compiled oso's, we also look for this particular case upon reading the oso, in loadshader.cpp, and mark it correctly. This was PR AcademySoftwareFoundation#922. Except... 1) We neglected to distinguish the 2-arg version from the 3-arg version, only the latter of which should be so marked. 2) We tested for regex_search twice (!) instead of testing for regex_search and also regex_match. Apologies! Here is the fix. Thanks to Alex Wells for identifying the problem. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an oslc bug a long time ago (prior to OSL 1.10) in which the
3-argument versions of regex_search and regex_match failed to mark
their 'results' parameter as write-only in the oso.
In addition to fixing the bug in oslc so that subsequently-produced
oso files are correct, in order to properly interpret these
historically-compiled oso's, we also look for this particular case
upon reading the oso, in loadshader.cpp, and mark it correctly. This
was PR #922.
Except...
We neglected to distinguish the 2-arg version from the 3-arg version,
only the latter of which should be so marked.
We tested for regex_search twice (!) instead of testing for
regex_search and also regex_match.
Apologies! Here is the fix.
Thanks to Alex Wells for identifying the problem.
Signed-off-by: Larry Gritz lg@larrygritz.com