AAF Adapter: Mob transcription heuristics #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we describe our AAF into OTIO space, we apply the following heuristic: 1) First look for top level mobs and if found use that to transcribe. 2) If we don't have top level mobs, look for composition mobs and use them to transcribe. 3) Lastly if we don't have either, try to use master mobs to transcribe. If we don't find any Mobs, just tell the user and do transcrption on an empty list (to generate some 'empty-level' OTIO structure) This heuristic is based on 'real-world' examples. There may still be some corner cases / open questions (like could there be metadata on both a composition mob and master mob? And if so, who would 'win'?) In any way, this heuristic satisfies the current set of AAFs we are using in our test-environment.
jchen9
changed the title
meshula
reviewed
Mar 23, 2022
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
meshula
approved these changes
Mar 23, 2022
andrewmoore-nz
added a commit
to thecargocultnz/OpenTimelineIO
that referenced
this pull request
Apr 5, 2022
* main: Add Python 3.10 to CI (AcademySoftwareFoundation#1256) Fix missing init metadata (AcademySoftwareFoundation#1251) Support OTIO_PLUGIN_MANIFEST_PATH being set to an emptry string (AcademySoftwareFoundation#1253) Add ALE adapter argument `ale_name_column_key` (AcademySoftwareFoundation#1248) AAF Adapter: Mob transcription heuristics (AcademySoftwareFoundation#1249) Bump src/deps/Imath from `bd6f74c` to `bd254da` (AcademySoftwareFoundation#1245) clang notices that constexpr can't be used on a mutating function (AcademySoftwareFoundation#1242)
jminor
pushed a commit
that referenced
this pull request
May 2, 2022
* Look for composition mob first if it's available When we describe our AAF into OTIO space, we apply the following heuristic: 1) First look for top level mobs and if found use that to transcribe. 2) If we don't have top level mobs, look for composition mobs and use them to transcribe. 3) Lastly if we don't have either, try to use master mobs to transcribe. If we don't find any Mobs, just tell the user and do transcrption on an empty list (to generate some 'empty-level' OTIO structure) This heuristic is based on 'real-world' examples. There may still be some corner cases / open questions (like could there be metadata on both a composition mob and master mob? And if so, who would 'win'?) In any way, this heuristic satisfies the current set of AAFs we are using in our test-environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we describe our AAF into OTIO space, we apply the following heuristic:
First look for top level mobs and if found use that to transcribe.
If we don't have top level mobs, look for composition mobs and use them to
transcribe.
Lastly if we don't have either, try to use master mobs to transcribe.
If we don't find any Mobs, just tell the user and do transcrption on an empty
list (to generate some 'empty-level' OTIO structure)
This heuristic is based on 'real-world' examples. There may still be some
corner cases / open questions (like could there be metadata on both
a composition mob and master mob? And if so, who would 'win'?)
In any way, this heuristic satisfies the current set of AAFs we are using
in our test-environment.