Fix #1257 missing each_clip on Clip #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup, looks like the code I removed, sorry! Not necessarily as part of this change, but should there also be a C++ equivalent? |
|
Probably it should exist for C++ as well, although my mind was only on the regression. |
|
LGTM for fixing the regression. |
andrewmoore-nz
added a commit
to thecargocultnz/OpenTimelineIO
that referenced
this pull request
Apr 5, 2022
* main: Detect & use Imath from vfxplatform CY2019-2022 (AcademySoftwareFoundation#1255) Fix AcademySoftwareFoundation#1257 missing each_clip on Clip (AcademySoftwareFoundation#1258)
jminor
pushed a commit
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Fixes #1257Summarize your change.
Pull #926 removed each_clip inadvertently from Clip. This change reintroduces it.