Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests in preparation for moving the aaf adapter #1353

Merged

Conversation

markreidvfx
Copy link
Contributor

@markreidvfx markreidvfx commented Jul 15, 2022

This pull request should keep all the coverage lost if #1348 was merged

Signed-off-by: Mark Reid <mindmark@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1353 (4648de5) into main (f54569f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
+ Coverage   86.18%   86.27%   +0.08%     
==========================================
  Files         196      196              
  Lines       19825    19865      +40     
  Branches     2309     2309              
==========================================
+ Hits        17087    17138      +51     
+ Misses       2171     2161      -10     
+ Partials      567      566       -1     
Flag Coverage Δ
py-unittests 86.27% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_clip.py 97.80% <100.00%> (+0.07%) ⬆️
tests/test_effect.py 96.07% <100.00%> (+1.63%) ⬆️
tests/test_item.py 98.66% <100.00%> (+0.05%) ⬆️
tests/test_transition.py 95.12% <100.00%> (+3.12%) ⬆️
...-opentimelineio/opentimelineio/core/_core_utils.py 78.21% <0.00%> (+0.77%) ⬆️
src/opentimelineio/transition.cpp 100.00% <0.00%> (+18.18%) ⬆️
src/opentimelineio/mediaReference.h 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54569f...4648de5. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it :)

@reinecke reinecke merged commit 913f540 into AcademySoftwareFoundation:main Jul 21, 2022
@ssteinbach ssteinbach added this to the Public Beta 15 milestone Aug 29, 2022
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
…wareFoundation#1353)

Signed-off-by: Mark Reid <mindmark@gmail.com>
Signed-off-by: Michele Spina <michelespina96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants