Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings on Windows #1414

Merged

Conversation

darbyjohnston
Copy link
Contributor

Signed-off-by: Darby Johnston darbyjohnston@yahoo.com

Fixes #1413

Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
@darbyjohnston darbyjohnston changed the title Fix warnings Fix compiler warnings on Windows Sep 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1414 (17c1ab1) into main (b9c2aa2) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1414   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files         201      201           
  Lines       21062    21062           
  Branches     2461     2461           
=======================================
  Hits        18127    18127           
  Misses       2333     2333           
  Partials      602      602           
Flag Coverage Δ
py-unittests 86.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/opentime/rationalTime.cpp 81.48% <100.00%> (ø)
src/opentimelineio/serialization.cpp 80.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c2aa2...17c1ab1. Read the comment docs.

@ssteinbach ssteinbach added this to the Public Beta 15 milestone Sep 23, 2022
@ssteinbach ssteinbach merged commit 0950f50 into AcademySoftwareFoundation:main Sep 24, 2022
@darbyjohnston darbyjohnston deleted the windows_warnings_fix branch September 24, 2022 02:31
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
Signed-off-by: Michele Spina <michelespina96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compiler warnings on Windows
4 participants