Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use glossary terms for environment variables references in the docs #1442

Conversation

JeanChristopheMorinPerso
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Oct 4, 2022

Summarize your change.

Simple PR that makes use of glossaries to define/document environment variables. This allows to reference environment variables from other places in the docs.

See https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-glossary.

The rendered docs can be seen at https://opentimelineio--1442.org.readthedocs.build/en/1442 and an example of how a reference looks like can be seen at https://opentimelineio--1442.org.readthedocs.build/en/1442/tutorials/write-an-adapter.html#custom-adapters.

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@ssteinbach ssteinbach added this to the Public Beta 16 milestone Oct 5, 2022
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1442 (d4c6c2b) into main (21970b8) will decrease coverage by 7.53%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
- Coverage   86.38%   78.85%   -7.54%     
==========================================
  Files         201      203       +2     
  Lines       20854    22246    +1392     
  Branches     2298     4517    +2219     
==========================================
- Hits        18014    17541     -473     
- Misses       2244     2437     +193     
- Partials      596     2268    +1672     
Flag Coverage Δ
py-unittests 78.85% <ø> (-7.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-opentimelineio/opentimelineio/plugins/manifest.py 87.14% <ø> (ø)
...elineio/opentimelineio-bindings/otio_anyVector.cpp 30.76% <0.00%> (-69.24%) ⬇️
...entimelineio-bindings/otio_serializableObjects.cpp 24.54% <0.00%> (-67.03%) ⬇️
...timelineio/opentime-bindings/opentime_bindings.cpp 33.33% <0.00%> (-66.67%) ⬇️
...eio/opentimelineio-bindings/otio_anyDictionary.cpp 33.33% <0.00%> (-66.67%) ⬇️
...imelineio/opentime-bindings/opentime_timeRange.cpp 32.39% <0.00%> (-61.36%) ⬇️
...ineio/opentime-bindings/opentime_timeTransform.cpp 42.30% <0.00%> (-57.70%) ⬇️
src/opentimelineio/stackAlgorithm.cpp 31.25% <0.00%> (-51.11%) ⬇️
...lineio/opentime-bindings/opentime_rationalTime.cpp 45.04% <0.00%> (-48.79%) ⬇️
src/opentimelineio/composition.h 40.74% <0.00%> (-48.15%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21970b8...d4c6c2b. Read the comment docs.

docs/Makefile Show resolved Hide resolved
@ssteinbach ssteinbach merged commit 51bee5f into AcademySoftwareFoundation:main Oct 10, 2022
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the use_terms_in_docs branch October 11, 2022 14:34
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
…cademySoftwareFoundation#1442)

* Use glossary terms for environment variables references in the docs
* Add documentation for livereload

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Michele Spina <michelespina96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants