Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of otioz file bundle structure in the docs #1606

Merged
merged 1 commit into from May 23, 2023
Merged

Fix rendering of otioz file bundle structure in the docs #1606

merged 1 commit into from May 23, 2023

Conversation

JeanChristopheMorinPerso
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented May 20, 2023 •
edited

@JeanChristopheMorinPerso
Fix rendering of otioz file bundle structure in the docs
929b904 
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1606 (929b904) into main (23ff3f9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1606   +/-   ##
=======================================
  Coverage   79.91%   79.91%           
=======================================
  Files         197      197           
  Lines       21731    21731           
  Branches     4339     4339           
=======================================
  Hits        17366    17366           
  Misses       2213     2213           
  Partials     2152     2152
Flag Coverage Δ
py-unittests 79.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ff3f9...929b904. Read the comment docs.

@meshula meshula requested a review from ssteinbach May 20, 2023 19:08
meshula
meshula approved these changes May 20, 2023
View reviewed changes
Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would be good to get a double-check from @ssteinbach

jminor
jminor approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meshula meshula merged commit c315a08 into AcademySoftwareFoundation:main May 23, 2023
40 checks passed
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
@JeanChristopheMorinPerso @MichaelPlug
Fix rendering of otioz file bundle structure in the docs (AcademySoft…
4db5fea 
…wareFoundation#1606)

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Michele Spina <michelespina96@gmail.com>
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the docs_fix_file_bundle_structure branch April 13, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jminor jminor jminor approved these changes

@meshula meshula meshula approved these changes

@ssteinbach ssteinbach Awaiting requested review from ssteinbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation formatting issues
4 participants
@JeanChristopheMorinPerso @codecov-commenter @jminor @meshula