-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add List of Supported Formats to Conform.py Help Text #676
Add List of Supported Formats to Conform.py Help Text #676
Conversation
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=======================================
Coverage 81.69% 81.69%
=======================================
Files 72 72
Lines 2731 2731
=======================================
Hits 2231 2231
Misses 500 500
Continue to review full report at Codecov.
|
examples/conform.py
Outdated
@@ -59,7 +59,8 @@ def parse_args(): | |||
type=str, | |||
required=True, | |||
help='Timeline file(s) to read. Any format supported by OTIO will' | |||
' work.' | |||
' work: fcp_xml, fcpx_xml, EDL, AAF, and more via community ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can take this a step further if you'd like and list the available adapters, using this function:
https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/9d010f2966523505b5c954d803f4f982f5e4edb5/src/py-opentimelineio/opentimelineio/console/otioconvert.py#L36
And if you want to put the file suffixes in the message, you can use this function:
https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/9d010f2966523505b5c954d803f4f982f5e4edb5/src/py-opentimelineio/opentimelineio/adapters/__init__.py#L52
Its a great idea to put that information into the file input argument! That upgrade could go into the real scripts (otioconvert, otioview, etc.) if you were interested in making the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it! Thank you for the info!
…vailable_adapter_names()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We should put this information in the other console scripts (in the python/py-opentimelineio/console directory), since its handy for users of those scripts to know what OTIO can read/write.
Thanks! Good idea!
* master: (23 commits) Indicate Empty track in otioview and display track name (AcademySoftwareFoundation#677) FCP 7 XML - Fix failure on empty name tags (AcademySoftwareFoundation#674) xges: Effects and Markers Support (AcademySoftwareFoundation#609) Add List of Supported Formats to Conform.py Help Text (AcademySoftwareFoundation#676) Update Copyright/License on ffmpeg_burnins.py (AcademySoftwareFoundation#679) Fix the windows build (AcademySoftwareFoundation#669) Version bump to beta 13 Set final version for beta 12.0 (AcademySoftwareFoundation#665) Rodeofx fix cmx 3600 multiple markers per clip issue 593 (AcademySoftwareFoundation#664) Tweaks to cmake so that pip and local builds both work (AcademySoftwareFoundation#663) Fixed issue where CMX3600 adapter would try to add the same clip to multiple tracks. Also moved some code out of a loop it didn't need to be in. (AcademySoftwareFoundation#644) RV adapter metadata updates (AcademySoftwareFoundation#640) Expose json indent to the otio_json adapter (AcademySoftwareFoundation#641) fix otioconvert for Kdenlive with python3 (AcademySoftwareFoundation#646) Add basic debugging instructions to quickstart. (AcademySoftwareFoundation#655) Add kdenlive adapter to adapters list. (AcademySoftwareFoundation#661) Timecode rate is ignored (AcademySoftwareFoundation#612) Detect if plugin doesn't have a docstring and return an error which says which plugin it is that doesn't have the docstring. (AcademySoftwareFoundation#635) Add hook function args to otioview and otioconvert (AcademySoftwareFoundation#651) Updating Copyright notices (AcademySoftwareFoundation#660) ... # Conflicts: # contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py # src/py-opentimelineio/opentimelineio/adapters/fcp_xml.py
Add list of supported files to tooltip for the conform.py example script.