CMake: Set "ARCHIVE DESTINATION" in install section #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where *.lib files wouldn't get installed on Windows.
ssteinbach
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
N/A
Summarize your change.
While
ARCHIVE DESTINATIONis usually used to define the destination of static library files, it also appears to be used for Windows/MSVC*.libfiles in general. When it isn't defined, the*.libfiles never get installed (only the DLLs do) and MSVC fails to link OTIO.Change is pretty minor, simply adds an extra line in the install section of
opentimelineioandopentimeto ensure Windows libs (and I guess static libs if there ever were any) get installed to thelibfolder.ARCHIVE DESTINATIONis described further here: https://cmake.org/cmake/help/v3.18/command/install.htmlReference associated tests.
No errors or issues appear to arise from this PR.