Add support for multiple timecode objects in an AAF #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshula
reviewed
May 11, 2021
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 85.61% 85.63% +0.01%
==========================================
Files 191 191
Lines 18212 18227 +15
Branches 2071 2074 +3
==========================================
+ Hits 15593 15608 +15
Misses 2088 2088
Partials 531 531
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ssteinbach
requested changes
May 11, 2021
There was a problem hiding this comment.
Looks great, just had some style things in there. Thanks @stefanschulze!
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/tests/test_aaf_adapter.py
Outdated
Show resolved
Hide resolved
…mat.py Co-authored-by: Stephan Steinbach <61017+ssteinbach@users.noreply.github.com>
…mat.py Co-authored-by: Stephan Steinbach <61017+ssteinbach@users.noreply.github.com>
Co-authored-by: Stephan Steinbach <61017+ssteinbach@users.noreply.github.com>
jminor
requested changes
May 11, 2021
meshula
reviewed
May 12, 2021
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
meshula
reviewed
May 12, 2021
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
ssteinbach
approved these changes
May 12, 2021
jminor
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the AAF reader is very strict if it comes to the number of discovered TimeCode objects in the AAF. If there is more than one TimeCode object found, the reader throws an exception.
However, there are situations where you can have multiple TimeCode objects, for example one created via the AuxTC24 bin-column in MediaComposer.
This change relaxes the rule a bit by accepting multiple TimeCode objects as long as they have the same start and length, in which case they are considered 'same'.
Also added an AAF with such multiple TimeCode objects and updated test_aaf_adapter to just read that AAF to make sure it can be read without throwing an exception.