Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-versioned library symlinks in debug build. #1051

Conversation

mcmtroffaes
Copy link
Contributor

Follow-up from discussion at #1032.

Old behaviour for debug builds: libOpenEXR.so -> libOpenEXR-3_1.so (broken, target should be libOpenEXR-3_1_d.so)
New behaviour for debug builds: libOpenEXR_d.so -> libOpenEXR-3_1_d.so

(Also needs fixing in RB-2.5 and Imath, will follow that up once this is merged.)

Signed-off-by: Matthias C. M. Troffaes <matthias.troffaes@gmail.com>
@mcmtroffaes
Copy link
Contributor Author

mcmtroffaes commented Jun 12, 2021

One thing I'm not sure of is whether the test (NOT "${OPENEXR_LIB_SUFFIX}" STREQUAL "") should instead read (NOT "${OPENEXR_LIB_SUFFIX}${CMAKE_${uppercase_CMAKE_BUILD_TYPE}_POSTFIX}" STREQUAL ""). My gut feeling says "yes" but I thought it prudent to ask before adding it in.

EDIT: Scrap that comment... I think it's fine as it is, it seems it's just a guard to prevent symlink source and target to be identical: if ${OPENEXR_LIB_SUFFIX} is empty but ${CMAKE_${uppercase_CMAKE_BUILD_TYPE}_POSTFIX} is not, the link should not be created.

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cary-ilm cary-ilm merged commit e493c13 into AcademySoftwareFoundation:master Jun 14, 2021
@mcmtroffaes mcmtroffaes deleted the feature/fix-debug-symlinks branch June 14, 2021 07:02
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request Jun 23, 2021
…undation#1051)

Signed-off-by: Matthias C. M. Troffaes <matthias.troffaes@gmail.com>
cary-ilm pushed a commit that referenced this pull request Jun 30, 2021
Signed-off-by: Matthias C. M. Troffaes <matthias.troffaes@gmail.com>
@cary-ilm cary-ilm added the v3.0.5 label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants