Implements #15, request for hardware concurrency utility function #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency utility function new static member of ThreadPool, call as ThreadPool::hardwareConcurrency, so no abi breakage or api change Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
lgritz
reviewed
Jul 17, 2019
|
same question as Larry, see this comment by @cary-ilm - #443 (comment) |
|
+1 for letting the user use |
|
This function, when in c++11 mode is just the same (and why I called it what I did), clients can use whatever. We haven't removed the old c++98 code yet, and this ticket was on my assigned list, so I did something about it :) |
meshula
approved these changes
Jul 17, 2019
After discussion with phillman, renamed to give this routine a purpose beyond some soon to be deleted legacy support, and clarified this in the comment documenting the function. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new static member of ThreadPool, call as
ThreadPool::hardwareConcurrency, so no abi breakage or api change
Signed-off-by: Kimball Thurston kdt3rd@gmail.com