don't index empty array in testMultiPartSharedAttributes #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cary-ilm
reviewed
Jul 16, 2019
| @@ -152,7 +152,7 @@ testMultiPartOutputFileForExpectedFailure (const vector<Header> & headers, | |||
| try | |||
| { | |||
| remove(fn.c_str()); | |||
| MultiPartOutputFile file(fn.c_str(), &headers[0],headers.size()); | |||
| MultiPartOutputFile file(fn.c_str(), (headers.size()>0 ? &headers[0] : NULL) , headers.size() ); | |||
There was a problem hiding this comment.
Wouldn't header.data() be a more proper way of accessing the data?
There was a problem hiding this comment.
Yes it would, but is vector::data() available in all C++ versions that are supported by OpenEXR?
|
The docs say C++11, and that's what we're relying on now, so it should be
fine.
…On Tue, Jul 16, 2019 at 2:54 PM peterhillman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In OpenEXR/IlmImfTest/testMultiPartSharedAttributes.cpp
<#443 (comment)>:
> @@ -152,7 +152,7 @@ testMultiPartOutputFileForExpectedFailure (const vector<Header> & headers,
try
{
remove(fn.c_str());
- MultiPartOutputFile file(fn.c_str(), &headers[0],headers.size());
+ MultiPartOutputFile file(fn.c_str(), (headers.size()>0 ? &headers[0] : NULL) , headers.size() );
Yes it would, but is vector::data() available in all C++ versions that are
supported by OpenEXR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#443>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFC3DGO2WJJM4QZ3BLJSL43P7Y7TFANCNFSM4ID6JDNA>
.
--
Cary Phillips | R&D Supervisor | ILM | San Francisco
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #377