Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #461, issue with macos rpath support #465

Merged
merged 1 commit into from
Jul 21, 2019
Merged

Fix #461, issue with macos rpath support #465

merged 1 commit into from
Jul 21, 2019

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Jul 21, 2019

Also removes half-baked framework support which wasn't going to work anyway

Signed-off-by: Kimball Thurston kdt3rd@gmail.com

@kdt3rd
Fix AcademySoftwareFoundation#461, issue with macos rpath support, re…
b913093 
…move half-baked framework support

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
meshula
meshula approved these changes Jul 21, 2019
View reviewed changes
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A framework bundle would be nice at some point, but working correctly at all is a huge improvement :)

@kdt3rd kdt3rd merged commit 9aa52c8 into AcademySoftwareFoundation:master Jul 21, 2019
@kdt3rd kdt3rd deleted the fix_461 branch July 21, 2019 08:01
@cary-ilm cary-ilm added this to the v2.4.0 milestone Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meshula meshula meshula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kdt3rd @meshula @cary-ilm