-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize mutex #802
Modernize mutex #802
Conversation
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Also deprecates Lock Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
src/lib/IlmThread/IlmThreadMutex.h
Outdated
@@ -146,7 +70,7 @@ class ILMTHREAD_EXPORT Lock | |||
} | |||
} | |||
|
|||
~Lock () | |||
inline ~Lock () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't class methods with implementations right in the class declaration implicitly inline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I was originally trying to remove this entirely, then realized I couldn't and didn't rollback my attempt to make the functions declared later. Will kill those inline
LGTM, pending whatever fixes make the CI pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as Larry vis a vis inline. Sure is nice to see all that platform code evaporate! Thanks!
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
fyi, CI still failing pending the imath external project changes, merging this in ahead of that |
This patch removes the custom implementations of mutex in favor of the c++11 provided thread utility provided version. It retains the header file with deprecation warnings, but otherwise removes use of this from the code