Modernize mutex #802
Merged
Modernize mutex #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Also deprecates Lock Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
lgritz
reviewed
Aug 1, 2020
src/lib/IlmThread/IlmThreadMutex.h
Outdated
| @@ -146,7 +70,7 @@ class ILMTHREAD_EXPORT Lock | |||
| } | |||
| } | |||
|
|
|||
| ~Lock () | |||
| inline ~Lock () | |||
There was a problem hiding this comment.
Aren't class methods with implementations right in the class declaration implicitly inline?
There was a problem hiding this comment.
yeah, I was originally trying to remove this entirely, then realized I couldn't and didn't rollback my attempt to make the functions declared later. Will kill those inline
lgritz
reviewed
Aug 1, 2020
lgritz
approved these changes
Aug 1, 2020
|
LGTM, pending whatever fixes make the CI pass. |
meshula
approved these changes
Aug 3, 2020
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
|
fyi, CI still failing pending the imath external project changes, merging this in ahead of that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the custom implementations of mutex in favor of the c++11 provided thread utility provided version. It retains the header file with deprecation warnings, but otherwise removes use of this from the code