Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rez-depends" and "private_build_requires ". #442

Closed
KelSolaar opened this issue Jul 9, 2017 · 4 comments
Closed

"rez-depends" and "private_build_requires ". #442

KelSolaar opened this issue Jul 9, 2017 · 4 comments

Comments

@KelSolaar
Copy link
Contributor

KelSolaar commented Jul 9, 2017

Hi,

I noticed that rez-depends does not list the private_build_requires attribute:

private_build_requires = [
    'git',
    'python',
    'rez_api']

Would be something great to have as a command line argument.

Cheers,

Thomas

bfloch pushed a commit to ToonBoxEntertainment/rez that referenced this issue Jul 12, 2017
…ivate_build_requires options to rez-depends
@bfloch
Copy link
Contributor

bfloch commented Jul 12, 2017

This was bugging us for a while, too. I just implemented this in pull-request #444
Enjoy.

These are the additional options. They are opt-in to not break compatibility.

  -b, --build-requires
                        Include build_requires             
  -p, --private-build-requires                             
                        Include private_build_requires     

@bfloch
Copy link
Contributor

bfloch commented Dec 16, 2017

@nerdvegas This can be closed now after the merge. Thanks!

@nerdvegas
Copy link
Contributor

I need to update this actually, for 2 reasons.

  1. There's currently a bug, this doesn't work for released packages because private_build_requires is stripped at release time (easily fixed)
  2. The -p arg needs to specify a particular package - it doesn't make sense to expose the private build reqs of all packages, as this does not represent any real env that ever gets resolved. Only the private build reqs of a package being built directly are ever included in a resolve.

@nerdvegas nerdvegas mentioned this issue Dec 13, 2018
@nerdvegas
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants